Use unix domain sockets instead of pipes for SSH RPC #1077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-schilling
approved these changes
Dec 16, 2022
Unline pipes, UDSs can be opened in a non-blocking way. And unlike pipes, when opened in a non-blocking way they will still signal EOF. This should solve the issue with early git stdout EOF commit-id:233e2cae
vlad-ivanov-name
force-pushed
the
pr/vlad-ivanov-name/ssh-rpc-fix/233e2cae
branch
from
8e4bfe8 to
729f922
Compare
vlad-ivanov-name
deleted the
pr/vlad-ivanov-name/ssh-rpc-fix/233e2cae
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike pipes, UDSs will still signal EOF when opened in a non-blocking way.
This should solve the issue with early git stdout EOF