Fix workspace discovery #1470
Merged
Fix workspace discovery #1470
+107
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-schilling
force-pushed
the
@changes/master/christian.schilling.de@gmail.com/fix-ws-discovery
branch
from
52310e7 to
238b5f3
Compare
The workspace discovery logic looks for all workspace.josh files in the tree and populates the "known filters" list. However a workspace.josh file in the root of the tree results in a filter with invalid syntax, so it is skipped now. Change: fix-ws-discovery
christian-schilling
force-pushed
the
@changes/master/christian.schilling.de@gmail.com/fix-ws-discovery
branch
from
238b5f3 to
3f8bb89
Compare
lmgivelaccenture
approved these changes
Sep 8, 2025
lmgivelaccenture
approved these changes
Sep 8, 2025
LMG
approved these changes
Sep 8, 2025
christian-schilling
deleted the
@changes/master/christian.schilling.de@gmail.com/fix-ws-discovery
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workspace discovery logic looks for all
workspace.josh files in the tree and populates
the "known filters" list.
However a workspace.josh file in the root of the
tree results in a filter with invalid syntax, so it is skipped now.
Change: fix-ws-discovery