Don't pack refs anymore #761
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-schilling
force-pushed
the
@changes/master/christian.schilling.de@gmail.com/no-packed-refs
branch
from
bcd3b5b to
2514037
Compare
|
Any idea of the impact of this on performance? |
|
Performance we will have to observe. Could be either way, but I suspect it will be better in most cases. Never really saw an advantage with the packing. |
LMG
approved these changes
Jun 13, 2022
auto-merge was automatically disabled
June 13, 2022 09:01
Pull request was closed
christian-schilling
force-pushed
the
@changes/master/christian.schilling.de@gmail.com/no-packed-refs
branch
from
2514037 to
b688f9e
Compare
christian-schilling
deleted the
@changes/master/christian.schilling.de@gmail.com/no-packed-refs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While ref packing makes iteration a bit faster, it causes contention
when accessed concurrently, in particular when refs are deleted.