Speed up history queries #894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
History queries where very slow because `find_original(...)` is executed on every commit. The idea of this optimisation is reduce the amount of history to traverse with each commit visited, taking advantage of the topological order of the traversal. Change-Id: history-query-optimisation
LMG
reviewed
Aug 24, 2022
| }; | ||
|
|
||
| { | ||
| rs_tracing::trace_scoped!("walk"); |
There was a problem hiding this comment.
maybe this scope can have a different name, like find_original
| } | ||
|
|
||
| fn hash(&self, context: &Context) -> FieldResult<String> { | ||
| rs_tracing::trace_scoped!("hash"); |
There was a problem hiding this comment.
Did you mean to keep those here?
LMG
approved these changes
Aug 24, 2022
LMG
deleted the
@changes/master/christian.schilling.de@gmail.com/history-query-optimisation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
History queries where very slow because
find_original(...)is executed on every commit.
The idea of this optimisation is reduce the amount of history
to traverse with each commit visited, taking advantage of the
topological order of the traversal.
Change-Id: history-query-optimisation