Skip to content

Restyle history view #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Restyle history view #916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions josh-ui/src/App.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,20 @@ nav {
}
}

.history-list-entry .summary {
@include ui-link-clickable;
&:hover {
background: $color-background-highlight;
}
}

.history-list-entry .hash {
@include ui-link-clickable;
&:hover {
background: $color-background-highlight;
}
}

.commit-list-entry-browse {
@include ui-link-clickable;
&:hover {
Expand All @@ -157,19 +171,24 @@ nav {

.commit-list-entry {
padding: .4em .4em;
display: block;

&:hover {
background: $color-background-highlight;
}

span.hash {
margin: 0 0.7em 0 0;
color: $color-highlight;
font-weight: bolder;
}
span.authorEmail {
float: right;
margin: 0 0.7em 0 0;
color: $color-highlight;
color: $color-font-shadowed;
font-weight: bolder;
}
span.summary {
display: block;
margin: 0 0.7em 0 0;
font-weight: bolder;
}
Expand Down
20 changes: 11 additions & 9 deletions josh-ui/src/History.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,17 +91,19 @@ export class HistoryList extends React.Component<HistoryBrowserProps, State> {

return values.map((entry) => {
return <div key={entry.hash} className="commit-list-entry">
<div
className="commit-list-entry-dir"
onClick={navigateChange.bind(this, entry.original.hash)}>
<span className="summary">{entry.summary}</span>
<div className="history-list-entry" >
<span
className="hash"
onClick={navigateBrowse.bind(this, entry.original.hash)}>
{entry.hash.slice(0,8)}
</span>
<span
className="summary"
onClick={navigateChange.bind(this, entry.original.hash)}>
{entry.summary}
</span>
<span className="authorEmail">{entry.authorEmail}</span>
</div>
<div
className="commit-list-entry-browse"
onClick={navigateBrowse.bind(this, entry.original.hash)}>
Browse
</div>
</div>

})
Expand Down