-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include feature #35
Include feature #35
Conversation
I think this is an excellent suggestion! I will pull, merge, and play with it tonight. It allows considerably more flexibility of layout and with a little thought could go somewhere towards MediaWiki-style templates - possibly using Selmer-like markup? |
Yea mediawiki templates seem to go in a similar direction. Regarding selmer - I like yogthos frameworks and use selmer a lot myself :-). But I think it's worth to stick in Markdown-Style (in terms of stay simple) to keep the markdown-wiki advantage on the one hand and not to introduce to much complexity in parsing and expression evaluation on the other hand (if you talk about the full selmer power). If you just talk about a different include-notation I'm completely open to your proposal :-) |
Aye. I've merged this, and will push a new minor release in a few moments (this and i18n). However, I would like you, if you would, to pull |
great ... I will write some docu ... think start of next week should be possible ... |
Here you find my proposal for a markdown include feature (as discussed in #34 :-).
You will be able to include other markdown pages with
&[:indent-heading s/Num :indent-list s/Num](relative or absolute url s/Str)
Defined indents will increase the indention of headings or lists, so you will be able to include the same page on different pages with varying indention levels. Some more thoughts and decisions you will find in
doc/include.md
At the moment Include works only in the same wiki via file system. Later on we can think of inter wiki links or github file urls for enhanced includes.
I've added two aditional libraries:
1.) plumatic schema - in order to describe introduced data structure. Maybe spec would also be a good choice.
2.) stuart sieras component in order to inject configuration and behavior for testing (specially test with uri resolving). I like spring in the java world and component in functional world helps to break up static dependency (cycles) in same way.
I think security will be a point left to implement - it may be possible to traverse more directories than intended at the moment. But first of all I'm interested in your feedback and thoughts :-)