fix bug introduced from dnspython dep upgrade #201
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
between version 1.12.0 and 1.14.0 of dnspython the return value of answer.target.to_text(omit_final_dot=True) has switched from a python string to a byte string, causing this exception to be thrown .
etcd.EtcdException: Could not get the list of servers, maybe you provided the wrong host(s) to connect to?further up the stack trace is this
urllib3.exceptions.MaxRetryError: HTTPConnectionPool(host="b'example.com'", port=2379): Max retries exceeded with url: /v2/machines (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f1eb30af5f8>: Failed to establish a new connection: [Errno -2] Name or service not known',))notice the host argument.
calling .decode() on the string returned from dns.resolver.query() fixes this issue.