Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: add supported engines #580

Merged
merged 1 commit into from May 14, 2018
Merged

Chore: add supported engines #580

merged 1 commit into from May 14, 2018

Conversation

@JPeer264
Copy link
Collaborator

@JPeer264 JPeer264 commented May 14, 2018

These engines settings should support Node v6 and v8+

(ref: #579)

@coveralls
Copy link

@coveralls coveralls commented May 14, 2018

Coverage Status

Coverage remained the same at 86.826% when pulling 1a75c9c on chore/engines into 10f3a88 on master.

Loading

Copy link
Collaborator

@RyanZim RyanZim left a comment

I'm fine with this as long as we remember to update it.

Loading

@jprichardson
Copy link
Owner

@jprichardson jprichardson commented May 14, 2018

Any reason to explicitly forbid Node v7?

Loading

@RyanZim
Copy link
Collaborator

@RyanZim RyanZim commented May 14, 2018

It's already EOLed, and we don't test on it.

Loading

@JPeer264
Copy link
Collaborator Author

@JPeer264 JPeer264 commented May 14, 2018

@jprichardson I took the .travis.yml node versions and #564 as resource for this decision

Loading

@jprichardson jprichardson merged commit 3eceb91 into master May 14, 2018
5 checks passed
Loading
@jprichardson jprichardson deleted the chore/engines branch May 14, 2018
facebook-github-bot added a commit to facebook/flipper that referenced this issue Nov 14, 2018
Summary:
Changes are mostly bug fixes, that shouldn't affect us. From the change log:

7.0.1 / 2018-11-07
------------------

- Fix `removeSync()` on Windows, in some cases, it would error out with `ENOTEMPTY` ([#646](jprichardson/node-fs-extra#646))
- Document `mode` option for `ensureDir*()` ([#587](jprichardson/node-fs-extra#587))
- Don't include documentation files in npm package tarball ([#642](jprichardson/node-fs-extra#642), [#643](jprichardson/node-fs-extra#643))

7.0.0 / 2018-07-16
------------------

- **BREAKING:** Refine `copy*()` handling of symlinks to properly detect symlinks that point to the same file. ([#582](jprichardson/node-fs-extra#582))
- Fix bug with copying write-protected directories ([#600](jprichardson/node-fs-extra#600))
- Universalify `fs.lchmod()` ([#596](jprichardson/node-fs-extra#596))
- Add `engines` field to `package.json` ([#580](jprichardson/node-fs-extra#580))

6.0.1 / 2018-05-09
------------------

- Fix `fs.promises` `ExperimentalWarning` on Node v10.1.0 ([#578](jprichardson/node-fs-extra#578))

6.0.0 / 2018-05-01
------------------

- Drop support for Node.js versions 4, 5, & 7 ([#564](jprichardson/node-fs-extra#564))
- Rewrite `move` to use `fs.rename` where possible ([#549](jprichardson/node-fs-extra#549))
- Don't convert relative paths to absolute paths for `filter` ([#554](jprichardson/node-fs-extra#554))
- `copy*`'s behavior when `preserveTimestamps` is `false` has been OS-dependent since 5.0.0, but that's now explicitly noted in the docs ([#563](jprichardson/node-fs-extra#563))
- Fix subdirectory detection for `copy*` & `move*` ([#541](jprichardson/node-fs-extra#541))
- Handle case-insensitive paths correctly in `copy*` ([#568](jprichardson/node-fs-extra#568))

Reviewed By: jknoxville

Differential Revision: D13023753

fbshipit-source-id: 1ecc6f40be4c8146f92dd29ede846b5ab56765ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants