-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.1.1: Add bonus minions for necromancy level if configured to use limits #117
2.1.1: Add bonus minions for necromancy level if configured to use limits #117
Conversation
|
||
var playerNecromancyLevel = | ||
Player.m_localPlayer.GetSkillLevel(SkillManager.Instance.GetSkill(BasePlugin.NecromancySkillIdentifier).m_skill); | ||
var bonusMinions = DraugrMinion.MinionLimitIncrementsEveryXLevels.Value > 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong minion type (draugr instead of skelly)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, thanks
…on-necromancy-skill-level
…gr limit was being used for skeletons
|
Aw man, could've sworn I accounted for that possibility... haha. Thanks |
Oh wait, you did. It was just because you checked one and used the other, which means it will be resolved with #117 (comment) |
Ah ok, phew. Thanks for the great and comprehensive testing |
Compiled: here
Testing:
Please tick the box as you complete each test segment.