Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.1.1: Add bonus minions for necromancy level if configured to use limits #117

Conversation

jpw1991
Copy link
Owner

@jpw1991 jpw1991 commented Mar 1, 2023

Compiled: here

Testing:

Please tick the box as you complete each test segment.

  • Base functionality test
    • Delete your config file
    • Start game
    • Ensure that you can summon unlimited minions
    • Quit game
  • Limit increment test
    • Edit config file to impose a limit on skeletons and draugr (different limit for each)
    • Edit the incrementer for each minion type (or leave it as default of 10)
    • Start game and check that you are being permitted to get new minions each time you get another X levels of Necromancy skill
    • Quit game
  • Limit no increment test
    • Edit config file to have incrementers set to 0
    • Ensure that the limit can't be passed and that no extra minions are given as necromancy level increases
  • Mixture test
    • To be exceedingly thorough, test incrementer with skeletons works well without an incrementer on the draugr, and vice versa


var playerNecromancyLevel =
Player.m_localPlayer.GetSkillLevel(SkillManager.Instance.GetSkill(BasePlugin.NecromancySkillIdentifier).m_skill);
var bonusMinions = DraugrMinion.MinionLimitIncrementsEveryXLevels.Value > 0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong minion type (draugr instead of skelly)

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks

@CW-Jesse
Copy link
Collaborator

CW-Jesse commented Mar 3, 2023

There's a divide by zero error when either MinionLimitIncrementsEveryXLevels is set to 0.

@jpw1991
Copy link
Owner Author

jpw1991 commented Mar 3, 2023

There's a divide by zero error when either MinionLimitIncrementsEveryXLevels is set to 0.

Aw man, could've sworn I accounted for that possibility... haha. Thanks

@CW-Jesse
Copy link
Collaborator

CW-Jesse commented Mar 3, 2023

Oh wait, you did. It was just because you checked one and used the other, which means it will be resolved with #117 (comment)

@jpw1991
Copy link
Owner Author

jpw1991 commented Mar 3, 2023

Oh wait, you did. It was just because you checked one and used the other, which means it will be resolved with #117 (comment)

Ah ok, phew. Thanks for the great and comprehensive testing

@jpw1991 jpw1991 merged commit ed6e8bf into master Mar 3, 2023
@jpw1991 jpw1991 deleted the 71-ability-to-increase-minion-limit-based-on-necromancy-skill-level branch March 3, 2023 17:55
@jpw1991 jpw1991 restored the 71-ability-to-increase-minion-limit-based-on-necromancy-skill-level branch January 17, 2024 04:37
@jpw1991 jpw1991 deleted the 71-ability-to-increase-minion-limit-based-on-necromancy-skill-level branch January 17, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to increase minion limit based on necromancy skill level
2 participants