-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate using Hyperfine in benchmark scripts #98
Comments
Stale issue message |
@jqnatividad Let me know if this is being worked upon ? Or I can pick this up ! |
Hi @udsamani , @minhajuddin2510 just started working on it, but there's more stuff on the backlog he can work on. So yeah, have a go! |
Also, NYC's 311 data is a very interesting dataset, and I'd like to keep it as the reference benchmark data. But it'd be great if we parameterize the benchmark data so folks have the option to change it, and perhaps, maintain their own internal benchmarks using data that's more representative of their data workloads/pipelines. https://github.com/jqnatividad/qsv/blob/master/docs/PERFORMANCE.md#benchmarking-for-performance |
Hi @udsamani , just checking to see if you have any questions about the old benchmark script... |
With #542, we'll stick with the benchmark script, just making sure it runs the latest version of qsv, and just run the benchmark manually on release. Will revisit using hyperfine in the future when we attempt to integrate automating benchmark generation as part of the release process, and adding |
Stale issue message |
reopening and removing |
Awesome @minhajuddin2510 ! #98 has been a longstanding open issue and we can finally close it! The next step is to integrate the benchmark into GitHub Actions CI so it's automatically updated with each release. Thanks!
Finally implemented by @minhajuddin2510 in #1237 |
The current benchmark script has been improved, but it still lacks the rigor of a proper benchmark.
Investigate using hyperfine, and perhaps, we can even automate the benchmarks as part of the release process.
The text was updated successfully, but these errors were encountered: