Skip to content
This repository was archived by the owner on Dec 11, 2021. It is now read-only.

Conversation

arschmitz
Copy link
Contributor

Adds a test task which runs on travis also add csslint and cssmin,
this also moves all generated css to a dist/css folder and adds a non minified
version of the css as well.

Adds a test task which runs on travis also add csslint and cssmin,
this also moves all generated css to a dist/css folder and adds a non minified
version of the css as well.
@jzaefferer
Copy link
Contributor

Seems odd that you need cssmin when there's already outputStyle: "compressed". Otherwise diff looks good to me.

@@ -9,3 +9,4 @@ node_modules/
external/
icons/svg-min/
.sass-cache/
css
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be dist/? Or why does #50 change this line?

@arschmitz
Copy link
Contributor Author

I meant to add a note about why i was adding css min here. Its actually two fold.
1.) the compressed style is not as good as css min because it doe not re order and do a couple other minor things the improve copmressability with gzip.
2.) CSS min gives you final gzip size of the files it creates which is super important to know when working with bem, because gzip compressibility is important to keep file size down, since bem tends to bloat badly in terms of LOC but is a huge winner in final gzip'ed file size when done / ordered properly.

For reference on this see top coat here https://docs.google.com/presentation/d/1_15yz1uT-oq17ZNsZTczGgwUh-TP15gGO6DFcz_XTJU/edit#slide=id.g688356856_20

@arschmitz arschmitz closed this in 252a28d Mar 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants