This repository was archived by the owner on Oct 8, 2021. It is now read-only.
Fixes issue #4114 - mini listview not supported #4464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So this just removes the mini option and will ignore the attribute if set on a list, right? If so, you can commit this to master and cherry pick to 1.1-stable. |
|
That's correct. |
jaspermdegroot
added a commit
that referenced
this pull request
May 28, 2012
Fixes issue #4114 - mini listview not supported
jaspermdegroot
added a commit
that referenced
this pull request
May 28, 2012
jaspermdegroot
added a commit
that referenced
this pull request
May 28, 2012
This reverts commit 83359a9.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed at #4114 we are not supporting data-mini="true" on listviews.
This commit removes the option from the JS. No changes in CSS needed.