-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asset compilation issue on Heroku #9
Comments
I'm deploying an app to Heroku with jquery-ui-rails myself, and it's working fine for me, so I'd need some more info on how to reproduce it. Since there are a lot of things that can go wrong with Heroku: Could this be a transient glitch (related to today's outage)? Or if not, are you 100% sure that the only thing you're changing is the one If you still think it's jquery-ui-rails, could you try and provide some more info (a) about your app and (b) about the error message (more log output, etc.)? |
Heroku seems to have stopped timing out, instead it just sits there indefinitely now, so this could be related to their outage, but I'm not sure. When I remove the gem it deploys just fine, re-adding the gem breaks every time. Since it doesn't timeout I'm unable to post any additional logging, although it appeared totally useless which is why I omitted it above. Digging a little deeper, I replicated the gem's vendor/assets content to my app, along with the "all" inclusions in my js and css manifests and was able to reproduce the problem upon pushing to Heroku. Here's the strange part: I then replaced the contents of vendor/assets/javascripts with a single jquery-ui file from jquery.ui.com and was able to successfully push to Heroku. This is on the Cedar stack using Ruby 1.9.3. |
Weird. I can't reproduce it with my Solitr app on Cedar, even with Ruby 1.9.3. Heroku's precompiling my assets at deploy time too. Just to make sure, have all the different log types on https://devcenter.heroku.com/articles/logging not returned any helpful error messages at all? |
Sorry for the delay in writing back. I just re-attempted the addition of the gem and it continues to break slug compilation, but Heroku is spitting out the timeout error once again:
Unfortunately, the only relevant logging provides no detail:
|
It is happening to me as well in few projects coz of too many assets files to precompile and heroku timeouts. While it is not directly related to jquery-ui-rails I got it working by fork-ing the gem and removing all datepicker i18n files. |
Hm, that's interesting. Let's leave this issue open for now so people with similar problems will find it. I wonder if we can somehow make the precompiler take less time on the unused i18n files. For what it's worth, I ended up finding the precompiling on Heroku to be too tricky and unreliable (e.g. having to set |
I faced a similar issue where all the assets files were pre-compiled which took as long as 15 to 20 minutes in production. (none of the files were called from application.js) Removing the jquery-ui-rails gem from application brought back pre-compilation time to under a minute... |
+1, we're experiencing the same issue here. Any hints or should we go by @iuliancostan? |
I just committed a possible fix to master. Can you see if it solves your problem and report back here, please? group :assets do
gem 'jquery-ui-rails', :git => 'https://github.com/joliss/jquery-ui-rails'
end |
It worked for me like a charm, thanks ! |
Glad it's fixed for you! I still can't reproduce the problem myself. Heroku precompilation works just as fast with or without the fix. @kjohnston @iuliancostan @jimishjoban @franciscoj Can you guys try this too and see if it fixes the precompilation slowness/timeouts for you? group :assets do
gem 'jquery-ui-rails', :git => 'https://github.com/joliss/jquery-ui-rails'
end |
It works for me. Thank you. |
Thanks for letting me know. I just pushed version 2.0.0 then. |
Hi, |
+1 |
Upon adding the gem and deploying to Heroku's Cedar stack, asset compilation fails. After a few minutes it times out and leaves behind the following tidbits:
...
The text was updated successfully, but these errors were encountered: