jQuery.extend: Separate the one-argument signature from the multiple-arguments one #1170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arguments one This is done to reduce the confusion as the single-argument signature behaves completely differently than the other one. Ref jquery/jquery#4748 Fixes jquerygh-1164
|
Before: After: |
|
Is the order fine or would it be better to have the separated single-arg signature immediately follow the first one? |
|
@mgol fwiw, I like the way you have it, because the first 2 now seem more closely related conceptually. |
timmywil
approved these changes
Jul 27, 2020
Yeah, that was my thinking as well. I'm glad you like it. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done to reduce the confusion as the single-argument signature behaves
completely differently than the other one.
Ref jquery/jquery#4748
Fixes gh-1164