Selectmenu: Add documentation for _renderButtonItem extension point #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var buttonItem = $( "<span>", { | ||
| "class": "ui-selectmenu-text" | ||
| }) | ||
| this._setText( buttonItem, item.label ); |
There was a problem hiding this comment.
Is calling _setText() a requirement of a _renderButtonItem() extension? If so it would be good to mention in the <desc>.
There was a problem hiding this comment.
It set's the text on the element but it's not required. One could do:
_renderButtonItem = function( item ) {
return $( "<span>", {
"class": "ui-selectmenu-text",
text: item.label
});
};
|
The indentation in this file is off. Other than that and my other minor comment this looks good. We can land this with #223 whenever the code itself is merged in. |
fnagel
force-pushed
the
selectmenu-render-button
branch
from
32604c8
to
9a14fc1
Compare
|
Fixed the indentation. |
| .css( "padding-left", "2.5em" ) | ||
| .append( "<span>" ) | ||
| .find( "span" ) | ||
| .addClass( "ui-icon " + item.element.attr( "data-icon") ) |
fnagel
added a commit
that referenced
this pull request
Nov 4, 2014
|
Changed the example and landed in 234c811 (created 1-12 branch). |
fnagel
added a commit
that referenced
this pull request
Feb 24, 2015
fnagel
added a commit
that referenced
this pull request
Mar 27, 2015
fnagel
added a commit
that referenced
this pull request
Apr 20, 2015
fnagel
added a commit
that referenced
this pull request
Apr 22, 2015
fnagel
added a commit
that referenced
this pull request
May 7, 2015
fnagel
added a commit
that referenced
this pull request
Sep 30, 2015
fnagel
added a commit
that referenced
this pull request
Oct 28, 2015
fnagel
added a commit
that referenced
this pull request
Oct 29, 2015
fnagel
added a commit
that referenced
this pull request
Dec 17, 2015
jzaefferer
pushed a commit
that referenced
this pull request
Jul 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.