Skip to content

Build: enable coveralls repro & allow testing \w building #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Build: enable coveralls repro & allow testing \w building #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Gruntfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,16 +61,16 @@ module.exports = function( grunt ) {
coverage: {
disposeCollector: true,
instrumentedFiles: "temp/",
src: [ "dist/jquery-migrate.js" ],
htmlReport: "coverage/",
lcovReport: "coverage/",
src: [ "src/!(intro.js|outro.js)" ],
htmlReport: "coverage/html",
lcovReport: "coverage/lcov",
linesThresholdPct: 85
}
},
files: [ "test/**/*.html" ]
},
coveralls: {
src: "coverage/lcov.info",
src: "coverage/lcov/lcov.info",
options: {

// Should not fail if coveralls is down
Expand Down
37 changes: 32 additions & 5 deletions test/testinit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

TestManager = {
/*
* Load a version of a file based on URL parameters.
Expand All @@ -9,14 +8,34 @@ TestManager = {
* else Full or relative path to be used for script src
*/
loadProject: function( projectName, defaultVersion, isSelf ) {
var file,
var file, i,
lines = "",
urlTag = this.projects[ projectName ].urlTag,
matcher = new RegExp( "\\b" + urlTag + "=([^&]+)" ),
projectRoot = isSelf ? ".." : "../../" + projectName,
version = ( matcher.exec( document.location.search ) || {} )[ 1 ] || defaultVersion;

if ( version === "dev" ) {
file = projectRoot + "/dist/" + projectName + ".js";

// Order is important
file = [
"version",
"migrate",
"attributes",
"core",
"css",
"ajax",
"data",
"manipulation",
"effects",
"event",
"traversing",
"deferred"
];

for ( i = 0; i < file.length; i++ ) {
file[ i ] = projectRoot + "/src/" + file[ i ] + ".js";
}
} else if ( version === "min" ) {
file = projectRoot + "/dist/" + projectName + ".min.js";
} else if ( /^[\w\.\-]+$/.test( version ) ) {
Expand All @@ -30,8 +49,16 @@ TestManager = {
file: file
} );

// Prevents a jshint warning about eval-like behavior of document.write
document.write( "<script src='" + file + "'></script>" );
if ( typeof file === "string" ) {
document.write( "<script src='" + file + "'></script>" );

} else {
for ( i = 0; i < file.length; i++ ) {
lines += "<script src='" + file[ i ] + "'></script>";
}

document.write( lines );
}
},
init: function( projects ) {
var p, project;
Expand Down