Tabs: additional check against base href attribute if there is one. Fixed #7822, - ui.tabs with <base> tag #1005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixed #7822, - ui.tabs with <base> tag
|
The code works as is. Please read the ticket comments again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to
http://bugs.jqueryui.com/ticket/7822
http://bugs.jqueryui.com/ticket/8637
I tried to comply with the coding standards mentioned here:
#853
I read a lot of comments on these issues but I still do not know whether you generally do not want to add a feature to make tabs work with BASE-tag or if no-one has come up with something that seemed acceptable to you. If the first case is true, it would be very kind of you to add a short note to the issues or set them to "wontfix" instead.
Thanks.