Skip to content

Fix floating detection when sortable is initially empty (#9443) #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix floating detection when sortable is initially empty (#9443) #1035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf66dd5
Fix floating detection when sortable is initially empty (#9443)
gentooboontoo Jul 22, 2013
547c9da
Add issue ID
gentooboontoo Jul 22, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions tests/unit/sortable/sortable_options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,31 @@ test("{ cancel: Selector }", function() {
});
*/

test( "#9443: Could not drag any but last item toward last position from initially empty floated sortable with { axis: 'x' }", function() {
expect(1);
var item, i,
changeCount = 0,
element = $( "#sortable" ).empty().sortable({
axis: "x",
change: function() {
changeCount++;
}
});

for(i = 0; i < 5; i++) {
element.append( "<li>Item " + i + "</li>" );
}

item = element.find( "li" ).css( "float", "left" ).eq( -2 );

item.simulate( "drag", {
dx: 50,
dy: 0,
moves: 1
});
equal( changeCount, 1, "change fired once when dragging a floated sortable in it's own container" );
});

test( "#8792: issues with floated items in connected lists", function() {
expect( 2 );

Expand Down
2 changes: 1 addition & 1 deletion ui/jquery.ui.sortable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ $.widget("ui.sortable", $.ui.mouse, {
this.refresh();

//Let's determine if the items are being displayed horizontally
this.floating = this.items.length ? o.axis === "x" || isFloating(this.items[0].item) : false;
this.floating = o.axis === "x" || (this.items.length ? isFloating(this.items[0].item) : false);

//Let's determine the parent's offset
this.offset = this.element.offset();
Expand Down