Skip to content

Conversation

tjvantoll
Copy link
Member

...#9469: on( "menuselect" ) not firing every time.

…es #9469: on( "menuselect" )

not firing every time.
@tjvantoll
Copy link
Member Author

@kborchers Is this sane? I'm still not quite clear on the purpose of the mouseHandled flag and whether it makes sense to reset it here. See http://bugs.jqueryui.com/ticket/9469#comment:4.

Thanks.

@kborchers
Copy link
Member

Yeah, I think this makes sense. The mouseHandled flag prevents the click event from firing on the parent menu items in nested menus as the event bubbles up through the menus.

I would also probably remove the setting of mouseHandled on https://github.com/tjvantoll/jquery-ui/blob/d7d1aadb5e7fb14f0980844c2b297c33f949d411/ui/jquery.ui.menu.js#L78 since it will be handled in the call to select just below that.

@tjvantoll
Copy link
Member Author

I would also probably remove the setting of mouseHandled on https://github.com/tjvantoll/jquery-ui/blob/d7d1aadb5e7fb14f0980844c2b297c33f949d411/ui/jquery.ui.menu.js#L78 since it will be handled in the call to select just below that.

Ah, good call. It probably makes sense just to move that line under this.select( event ); instead of doing it in the method.

I feel better about this now. Thanks.

@tjvantoll
Copy link
Member Author

Rebased and landed in 484e382.

@tjvantoll tjvantoll closed this Aug 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants