...:Resizable dialogs move/resize out of viewport boundary - which results in scrollbar
Before I mess up the author information again, can you please rebase this PR on top of latest origin/master and change your git email address to the correct one? Thank you.
@jzaefferer i will rebase all my pending PRs , also i see some formatting issues .
Please hold on this PR , looks like moveToTop is failing in regression
@dekajp any progress on getting this reviewable?
@kborchers i think this PR can move forward. looks like moveToTop dialog: methods: moveToTop: content scroll stays intact is still failing in Chrome , where as it works in FF in my machine (mac os) . i updated my comment on this commit - e263ebd
dialog: methods: moveToTop: content scroll stays intact
sorry for delay
We've landed a few dialog fixes in master in the last two days, including the issue you commented on. If you've seen test failures unrelated to your patch (especially in IE8), rebasing should help.
@jzaefferer 2 tests are still failing on master branch but only for chrome-30 , it works in FF25 in MacOS. one dialog: options: resizable and dialog: options: #4826: setting resizable false toggles resizable on dialog . i think these are unrelated.
dialog: options: resizable
dialog: options: #4826: setting resizable false toggles resizable on dialog
on side note - i am executing these unit test cases in browser. my unit test case checks for scrollbar presence . on consecutive execution it fails.(i think because some other test case creates a scrollbar) but on individual execution it works.
i will look why travis build is failed. in my local machine looks like grunt jshint failed with unable to read true file ,but then grunt --force worked
unable to read true file
Dialog & Resizable: css styles fixed NE,SE,S,E handles. Fixed #9521 u…
…i.Dialog:Resizable dialogs move/resize out of viewport boundary - which results in scrollbar
@jzaefferer - build passed.
@mikesherov could you review this one?
@jzaefferer on it.
This one makes me nervous because I'm not the greatest with css. @scottgonzalez any input here. It seems like the issue just resolves the negative margins causing scrollies. But I don't feel comfortable that this won't cause any visual regressions.
Can't this be as simple as just adding overflow: hidden back to .ui-dialog?
overflow: hidden certainly seems to fix this issue: http://jsfiddle.net/tj_vantoll/tKQZ5/.
It was removed in 2c16435 because @scottgonzalez & I couldn't come up with a reason it was there. Apparently there is one.
@dekajp Would you be interested in testing out overflow: hidden and possibly sending a different pull request?
@scottgonzalez 👍 . i will test this out and send out a new PR
Dialog: Apply `overflow: hidden` to contain the resize handles
(cherry picked from commit 7741c9f)
@scottgonzalez - do you still need the unit test case ? for this or we can ignore it.
I don't think it's necessary, but if others think it's important, we can revisit it.