widget:option should work as getter only when argument length =1. Fix-ti... #1106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-ticket 9601 - Widget: calling _setOption with undefined as 3rd argument makes it a getter
| @@ -580,6 +585,12 @@ test( ".option() - deep option setter", function() { | |||
| deepOption( { bar: "baz" }, { bar: "qux" }, "one deep" ); | |||
| div.testWidget( "option", "foo.bar", "qux" ); | |||
|
|
|||
| deepOption( { bar: "baz" }, { bar: undefined }, "one deep - value = undefined" ); | |||
| //Note : this assertion will never run if - when option behave like getter | |||
There was a problem hiding this comment.
Space after "//", but you can probably just remove this comment altogether.
There was a problem hiding this comment.
i will remove this comment - resubmit code .
|
This looks good to me. |
|
Rebased this into a single commit, updating the commit message to match the guidelines and removed a trailing tab in the widget_method.js file, landed in ecde7cd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ticket 9601 - Widget: calling _setOption with undefined as 3rd argument makes it a getter
option: function( key, value )works as setter ifvalue=undefined. Fixedoptionto allow setkey=undefined