Resizable: Store size based on calculated helper size to prevent 1 pixel... #1107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test please! |
|
Yeah, after I sent that PR late last night I was like, "Oh crap, forgot a test!" I'll add one tonight :) |
|
@mikesherov test added |
|
@kborchers sorry to be a pain, but there's numerous whitespace issues here... I'm gonna just comment on each one. |
| @@ -191,4 +191,19 @@ test("resizable accounts for scroll position correctly (#3815)", function() { | |||
| equal( el.css("top"), top, "css('top') stays the same when resized" ); | |||
| }); | |||
|
|
|||
| test("resizable stores correct size when using helper and grid (#9547)", function() { | |||
|
Other than whitespace, 👍 |
|
OK, I can clean it up ... the reason I didn't is because that whole file is a whitespace nightmare so I just went with it. The whole thing needs a cleanup |
|
Word, I get it. We had resolved that all new code should match styles, regarding of surrounding code. Until we do a cleanup, it reduces the chances of users copypasta-ing bad style. Hopefully jscs or esformatter will automate this for us soon. |
…xel shifts. Fixes #9547 - Resizable: off-by-one pixel dimensions with helper and grid
|
@mikesherov cleaned up |
|
👍 |
|
Looks good to me. |
|
Landed in 14065dc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... shifts. Fixes #9547 - Resizable: off-by-one pixel dimensions with helper and grid