Skip to content

Conversation

dekajp
Copy link
Contributor

@dekajp dekajp commented Nov 22, 2013

I have not added any unit test cases for this fix . I do see that Sortable is in general missing parent containment and many others test cases . if you guys like the fix - i will try to add unit test cases for it.

Fiddle Fix link - http://jsfiddle.net/2bHSG/12/

…t has css max-height property set .Fixes #9460 - Sortable: containment doesn't work properly when scrolling
@mikesherov
Copy link
Member

@dekajp thanks for contributing as always. Even though sortable's current test suite is severely lacking, I'll need you to write a test proving this fixes the bug. If, while you're in there, you feel like writing some of the missing basic tests, that would be extremely appreciated. If you do, can you open a separate PR with just the tests?

Thanks again!

@dekajp
Copy link
Contributor Author

dekajp commented Dec 16, 2013

@mikesherov i am tied up with something i am working on for coming couple weeks. i will definitely try to find out some time to write these unit tests.

@mikesherov
Copy link
Member

Great thanks! No rush. Work comes first :)

@dekajp
Copy link
Contributor Author

dekajp commented Feb 2, 2014

/cc @mikesherov @scottgonzalez
Got involved with another project. not able to devote time to this project . So no point in keep this request open. Will work on this when come back "active" on this project.

@dekajp dekajp closed this Feb 2, 2014
@NoudL
Copy link

NoudL commented Jun 23, 2023

Was this ever fixed? Looks like it was never merged and I ran into a similar issue where scrolling breaks the containment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants