Refresh item positions after scroll #1209
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @victor-homyakov , Thanks for taking the time to contribute to jQuery UI. We have the following requirements of pull requests before we can review them.
I'm going to close this PR for now. If you would like to address these requirements please open a new PR. Thanks. |
|
There are 5 unit test modules (sortable_common.js, sortable_core.js, sortable_events.js, sortable_methods.js, sortable_options.js). Where should I add my unit test? |
|
For something like this I would use |
|
i want to merge this patch. may i help anything to merge this patch ? |
|
Unit test is the main problem. Write the failing test that will pass after proposed patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug http://bugs.jqueryui.com/ticket/8961
Test page: http://jsfiddle.net/Sb4GT/1/