Dialog: Fix resizing with iframes #1214
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the element that overlays iframes during dialog resize follows
the iframe size during the resize operation.
Fixes #9919
Quick fix for the iframe resizing issue. Few things that bother me though:
The iframe the div is overlaying is stored using $.data. Is there a better way and do we need to clear this reference in the _unblockFrames or is it enough to just delete the div itself?
Performance-wise we shouldn't need to iterate through all the iframes in
_resizeBlocks
. It should be enough to iterate through the iframes inside the current dialog as those are the only ones likely to change size. What would be the cleanest way to implement this? Storing them in different field in_blockFrames
,$(this).children().filter( this.iframeBlocks )
, giving them a className and using$(this).children("...")
or something else?