#10098 moving disabled tab click handlers onto role=tabpanel elements fo... #1261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }); | ||
|
|
||
| // bind events to ul for better Voiceover announcement | ||
| .find(".ui-tabs-nav") |
There was a problem hiding this comment.
This will bind to nested tabs as well. You can move this below the call to _processTabs() and then use this.tablist.
There was a problem hiding this comment.
This would need to be after _processTabs() anyway, since the class generally won't be added by users, so this won't find anything.
… for better Voiceover announcement
moving tab list event bindings for disabled li's from selector onto this.tablist inside of processTabs(). Adding an unbind call on tab list in destroy() for cleanup
|
@scottgonzalez moved delegation to |
|
ping @scottgonzalez is this something that might still be useful? |
|
Sorry, I was on vacation when you updated this, then I got busy with the 1.11.0 release. This looks good now. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...r better Voiceover announcement
Not sure if this is the best way to fix. Potentially this event binding is instead moved inside of
_processTabsas it has to happen on the elem withrole="tablist"to fix the bug