Skip to content

Slider: Reset positioning when orientation changes #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Slider: Reset positioning when orientation changes #1268

wants to merge 1 commit into from

Conversation

scottgonzalez
Copy link
Member

Fixes #10105

I think this is all that's needed.

@tjvantoll
Copy link
Member

Looks right to me. Not a huge deal, but it might be nice to have a test for this.

@scottgonzalez
Copy link
Member Author

Tests added. I had to drop down to the style property instead of .css() because the theme does use some positioning to center the handle.

@tjvantoll
Copy link
Member

👍

@scottgonzalez scottgonzalez deleted the slider-orientation branch October 7, 2014 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottgonzalez @tjvantoll