Skip to content

Selectmenu: Close on scroll #1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

scottgonzalez
Copy link
Member

Fixes #10082

scroll events don't bubble, so we need to bind directly to all ancestors. We should take the same approach for other widgets with popups.

@arschmitz
Copy link
Member

Not sure if this is really an issue or not but this causes the menu to close when you zoom in or out.

@tjvantoll
Copy link
Member

@arschmitz Do you mean on mobile? I'm not seeing that behavior on desktop browsers.

This looks good to me.

@tjvantoll
Copy link
Member

Actually I take that back. I just played with this change on a few mobile devices and the behavior is actually a bit annoying. If the menu doesn't quite fit in the viewport of the device, or you just want to zoom in to make sure you click the correct option, when you complete your pinch to zoom the browser fires a scroll event that closes the menu.

@arschmitz
Copy link
Member

@tjvantoll yes on mobile and yes very annoying

@arschmitz
Copy link
Member

@tjvantoll @scottgonzalez What we do in mobile is just hide the menu while scrolling and or resizing the window. We then reposition it once scrolling or resizing has stopped.

@scottgonzalez
Copy link
Member Author

Closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants