Progressbar: replace image reference in base CSS with data URI #1276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CSS for the Progressbar widget contained a reference to "images/animated-overlay.gif", which is not included in custom jQuery UI builds with "no theme" selected. This replaces the reference with a data URI.
|
@scottgonzalez Any concerns with this? It looks good to me. |
|
I'm still on the fence about this since it's really theme-related. But since we're already violating this with the image reference, I'm fine continuing to violate it with a data URI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CSS for the Progressbar widget contained a reference to
"images/animated-overlay.gif", which is not included in custom jQuery UI
builds with "no theme" selected. This replaces the reference with a data URI.
Fixes #10134.