Skip to content

Conversation

rxaviers
Copy link
Member

@rxaviers rxaviers commented Sep 2, 2014

💥 WIP...

Pulll request's goal is to AMDify demos for the 1.12.0 release and address part of http://bugs.jqueryui.com/ticket/10119.

@tjvantoll
Copy link
Member

My concern here is I don't know how we're going to convert jqueryui.com's build-demos task to replace this RequireJS configuration and define() wrapper with CDN links. Currently the logic looks for <script> and <link> tags, rips them out, and inserts the appropriate CDN links. Do you have any thoughts on how that might work?

@rxaviers
Copy link
Member Author

rxaviers commented Sep 3, 2014

Well observed. Technically, it's possible to use CDN links in the requirejs paths (like shown here). Although, do we want to depend on require.js on the jqueryui.com demos? If that's ok, we could first load http://cdnjs.cloudflare.com/ajax/libs/require.js/2.1.14/require.min.js, then use requirejs.config paths to load jquery and jquery-ui via cdn. This needs test.

@scottgonzalez
Copy link
Member

Can we close this until it's ready to be worked on again?

@rxaviers
Copy link
Member Author

Can we close this until it's ready to be worked on again?

Ok from me. Then, are we going to reopen it?

@scottgonzalez
Copy link
Member

If anyone ever works on it, yes.

@jzaefferer jzaefferer deleted the AMDify-demos branch May 15, 2015 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants