Calendar rebase (3) #1352
Closed
Calendar rebase (3) #1352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change status caching, fix existing value related methods, introduce $.date construction with date object, selected property is null by default, add selected getter
This was referenced Sep 29, 2014
Closed
fnagel
force-pushed
the
calendar-value-pr2
branch
4 times, most recently
from
bb556be to
c6f205f
Compare
Add calendar widget by copying and renaming datepicker widget files. Remove datepicker functionality, options and methods from Calendar. Remove calendar functionality, options and methods from Datepicker. Adjust tests due to split and changed specification. Remove duplicated demo files and fix some demos. Simplify calendar generation, use CSS instead of inline styles. Fix destroy method. Make use of uniqueId method. Fix focus highlighting when month is changed. Add version property. Add common unit tests. Fix input keyboard handling.
Improve render day cell mechanism.
Remove shortcut for closing the calendar and erasing the date (CTRL+END)
Several minor code improvements and make suppressExpandOnFocus an internal variable
Add Test if these options are set on the underlying calendar instance
fnagel
force-pushed
the
calendar-value-pr2
branch
from
c6f205f to
f2a51be
Compare
| } | ||
| if ( months[ i ].last ) { | ||
| headerClass = "ui-corner-right"; | ||
| } |
There was a problem hiding this comment.
If months[ i ].first and months[ i ].last are mutually exclusive, I suggest using else if.
There was a problem hiding this comment.
Changed. This should be the case as long as we have two different methods for creating single and multiple datepickers.
|
Opening the default datepicker demo results in "Uncaught Error: invalid value (undefined), string expected " |
|
@scottgonzalez That Uncaught Error: invalid value (undefined), string expected " is fixed. It's needed to catch undefined values in _getCreateOptions. |
|
@scottgonzalez Do you want me to open a new PR or should I force push my changes here? |
|
New PR every time, otherwise the discussion history is nearly impossible to follow. |
Merged
|
New PR: #1371 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #1316, but was itself replaced by #1371.