Menu: Maintain focus on already selected item during typeahead #1354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
| @@ -251,7 +251,7 @@ return $.widget( "ui.menu", { | |||
|
|
|||
| if ( match.length ) { | |||
| this.focus( event, match ); | |||
| if ( match.length > 1 ) { | |||
| if ( match.length > 0 ) { | |||
There was a problem hiding this comment.
Wouldn't we typically just write if ( match.length )?
There was a problem hiding this comment.
Actually, I'm wondering if this entire if check (and an else) can go away because the same thing is checked two lines earlier.
There was a problem hiding this comment.
@scottgonzalez Yeah this works fine with this check removed. Good catch. #1355
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10644