Sortable: cache original DOM position using all node types #1433
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10800 - Sortable: Cancelling a sort does not return the item to its original position with regard to non-element nodes by caching the original DOM position using
previousSibling
rather thanprev
, so all nodes are considered, not just elements.Here's the original JSFiddle showing the bug:
http://jsfiddle.net/morchard/pups17xL/
And here's a JSFiddle showing the patch:
http://jsfiddle.net/morchard/z60ox3so/