Slider: Modified to allow value reach max value with float step #1465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with step of 0.01 value did not reached max value Fixes #11286
| @@ -558,7 +558,7 @@ return $.widget( "ui.slider", $.ui.mouse, { | |||
| var max = this.options.max, | |||
| min = this._valueMin(), | |||
| step = this.options.step, | |||
| aboveMin = Math.floor( ( max - min ) / step ) * step; | |||
| aboveMin = Math.floor( ( +( max - min ).toFixed(5) ) / step ) * step; | |||
There was a problem hiding this comment.
Let's not use arbitrary precision. See
Line 328 in 18e301f
in "_calculateNewMax" difference between max and min was fixed to 5 precision Fixes #11286
|
Merged with some style updates. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with step of 0.01 value did not reached max value
Fixes #11286