Tooltip: Remove name and id from tooltip content #1525
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #11272
| "<input type='radio' name='hobby' checked='checked'><label>option 1</label>" + | ||
| "<input type='radio' name='hobby'><label>option 2</label>" + | ||
| "</div>", | ||
| stripped_content = "<div>" + |
There was a problem hiding this comment.
camelCase variable names.
|
Please update your git config to use your full name so that it matches your CLA signature. |
|
@jiabaowu Are you still interested in this? It's been a few weeks. |
|
@scottgonzalez sorry for the lack of contact, I meant to leave a comment on the bug report but I lost my account and the password reset wont send me an email. I think this fix is impossible, but since I refactored the code do you think it is worth resubmitting this PR to just remove "name" from the radio button in liveregion? edit: actually sorry, I see you mentioned that in your comment on the bug, sure ill try to submit! |
|
Replaced by #1544. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11272