New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete for Chrome Fixed #1596

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@exussum12

Chrome since Version 34 has not followed the standard "off" setting
setting to false seems to work on other browsers

Autocomplete for Chrome Fixed
Chrome since Version 34 has not followed the standard "off" setting
setting to false seems to work on other browsers
@exussum12

This comment has been minimized.

Show comment
Hide comment
@exussum12

exussum12 Sep 15, 2015

Not sure how to run the bot again, Fixed the error

Not sure how to run the bot again, Fixed the error

@scottgonzalez

This comment has been minimized.

Show comment
Hide comment
@scottgonzalez

scottgonzalez Sep 15, 2015

Member

It's working just fine for me. Do you have a link to a bug report or anything else to back up your statement?

Member

scottgonzalez commented Sep 15, 2015

It's working just fine for me. Do you have a link to a bug report or anything else to back up your statement?

@exussum12

This comment has been minimized.

Show comment
Hide comment
@exussum12

exussum12 Sep 15, 2015

The chrome issue
https://code.google.com/p/chromium/issues/detail?id=468153

Second answer here
http://stackoverflow.com/a/29582380/1281385
(78 upvotes currently)

No jQueryUI bug currently, but I can create one ?

Technically it should be a chrome only thing, But as false seems to work in other places, it doesnt seem harmful to change

The chrome issue
https://code.google.com/p/chromium/issues/detail?id=468153

Second answer here
http://stackoverflow.com/a/29582380/1281385
(78 upvotes currently)

No jQueryUI bug currently, but I can create one ?

Technically it should be a chrome only thing, But as false seems to work in other places, it doesnt seem harmful to change

@scottgonzalez

This comment has been minimized.

Show comment
Hide comment
@scottgonzalez

scottgonzalez Sep 15, 2015

Member

I'm skeptical of this fix. Looking at http://jsfiddle.net/4wq5cozo/, which is a test case from https://code.google.com/p/chromium/issues/detail?id=527408 (closed as a duplicate of the ticket you linked to), changing firstname2 to have autocomplete="false" disables all autofill on that page, not just for that field. That doesn't seem like a viable solution in jQuery UI.

Member

scottgonzalez commented Sep 15, 2015

I'm skeptical of this fix. Looking at http://jsfiddle.net/4wq5cozo/, which is a test case from https://code.google.com/p/chromium/issues/detail?id=527408 (closed as a duplicate of the ticket you linked to), changing firstname2 to have autocomplete="false" disables all autofill on that page, not just for that field. That doesn't seem like a viable solution in jQuery UI.

@exussum12

This comment has been minimized.

Show comment
Hide comment
@exussum12

exussum12 Sep 15, 2015

Hmm I see that, What about having an option passed on autocomplete to allow this ? Have the default as "off" but an option to set as false ?

Hmm I see that, What about having an option passed on autocomplete to allow this ? Have the default as "off" but an option to set as false ?

@scottgonzalez

This comment has been minimized.

Show comment
Hide comment
@scottgonzalez

scottgonzalez Sep 15, 2015

Member

Setting an option would be just as easy as doing .attr("autocomplete", "false");, so I don't see how that would help.

Member

scottgonzalez commented Sep 15, 2015

Setting an option would be just as easy as doing .attr("autocomplete", "false");, so I don't see how that would help.

@scottgonzalez

This comment has been minimized.

Show comment
Hide comment
@scottgonzalez

scottgonzalez Sep 23, 2015

Member

I'm going to close this PR since I don't think there's anything we can do. However, I am talking to Chrome developers to see if we can get some updates in the browser. I'll post updates here.

Member

scottgonzalez commented Sep 23, 2015

I'm going to close this PR since I don't think there's anything we can do. However, I am talking to Chrome developers to see if we can get some updates in the browser. I'll post updates here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment