Controlgroup fixes #1703
Closed
Controlgroup fixes #1703
+134
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unless its a corner class Fixes #14960
Fixes #14967
|
By analyzing the blame information on this pull request, we identified @jzaefferer, @apsdehal and @scottgonzalez to be potential reviewers |
| $.each( classes, function( key ) { | ||
| var current = instance.options.classes[ key ] || ""; | ||
| current = current.replace( removeClassRegex, "" ).trim(); | ||
| classes[ key ] = ( current + " " + classes[ key ] ).replace( / +/g, " " ); |
There was a problem hiding this comment.
Can you switch the space literal to \s in the regex?
arschmitz
force-pushed
the
controlgroup-fixes
branch
from
f562914 to
034d20d
Compare
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes various issues with controlgroups