[WIP] Draggable: Remove handle class when disabled to allow scrolling #1714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottgonzalez
force-pushed
the
draggable-touch-action
branch
from
71dff3b to
cd6320e
Compare
|
Updated the implementation and added tests. If this approach looks good, I'll update the other widgets. |
arschmitz
requested changes
Oct 5, 2016
| @@ -91,6 +94,15 @@ $.widget( "ui.draggable", $.ui.mouse, { | |||
| } | |||
| }, | |||
|
|
|||
| _setOptionDisabled: function( value ) { | |||
| // Remove touch-action for disabled draggables | |||
|
Is this related to https://forum.jquery.com/topic/jquery-ui-sortable-disables-scroll-on-android ? When this will be fixed ? |
|
I also have been impacted by this behavior. Is anyone currently working on finishing this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14779
I'd like to add a test for this before merging which checks if the
touch-actionproperty is set. I don't have time to do the necessary testing against IE right now though. We also need to handle sortable and selectable, but I wanted to get this started so I don't forget about it.