Skip to content

Calendar / Datepicker: improve tests and add missing events #1755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Nov 9, 2016
Merged

Calendar / Datepicker: improve tests and add missing events #1755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d1152a3
Calendar tests: Add select event unit tests
fnagel May 22, 2016
967e581
Calendar: Make sure keydown original event is available
fnagel May 22, 2016
85fe553
Calendar tests: Add dateEqual assertion, clean up helper methods
fnagel May 22, 2016
2963622
Datepicker tests: Use setup and teardown methods, remove helper file
fnagel May 22, 2016
18ad526
Calendar tests: Use setup and teardown methods
fnagel May 22, 2016
877937e
Calendar tests: Add basic value option tests
fnagel May 22, 2016
ea986f2
Datepicker: Add missing Globalize parse format for min / max attribute
fnagel May 28, 2016
9428256
Datepicker: Add min / max option tests
fnagel May 29, 2016
6f9d266
Datepicker: Fix min / max attribute and add proper option parsing
fnagel May 29, 2016
9fc83a0
Calendar: Add change event
fnagel May 29, 2016
96b5a76
Calendar tests: Simplify timeout steps
fnagel Oct 11, 2016
890510c
Calendar tests: Use assert.expect instead of global expect
fnagel Oct 11, 2016
f64a7a4
Calendar: Use name space for timestamp data attribute
fnagel Oct 11, 2016
bd488f9
Calendar: Clear value if an invalid input was given
fnagel Oct 12, 2016
f010087
Calendar: Clear value if an invalid min / max option value was given
fnagel Oct 24, 2016
2c43879
Datepicker: Use simple split instead of globalize for parsing attributes
fnagel Oct 25, 2016
68028e7
Calendar tests: use dateEqual assert instead of timestamp compare
fnagel Oct 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions tests/lib/qunit-assert-dateequal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
/*
* Assertion for comparing Date objects by day, month and year.
*/
define( [
"qunit"
], function( QUnit ) {

QUnit.assert.dateEqual = function( value, expected, message ) {

if ( !value || !expected ) {
this.push( false, value, expected,
"dateEqual failed, missing date object, message was: " + message );
return;
}

var newValue = new Date( value.getFullYear(), value.getMonth(), value.getDate() ),
newExpected = new Date( expected.getFullYear(), expected.getMonth(), expected.getDate() );

this.push( ( newValue.toString() === newExpected.toString() ), value, expected, message );
};

} );
1 change: 1 addition & 0 deletions tests/lib/qunit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ define( [
"qunit-assert-classes",
"qunit-assert-close",
"lib/qunit-assert-domequal",
"lib/qunit-assert-dateequal",
"phantom-bridge"
], function( QUnit, $ ) {

Expand Down
1 change: 1 addition & 0 deletions tests/unit/calendar/common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ common.testWidget( "calendar", {
value: null,

// callbacks
change: null,
create: null,
select: null
}
Expand Down
Loading