Ticket #7231 - Progresbar: valueDiv should be hidden when value is at 0% #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is greater than 0; fixes valueDiv background being visible even when progressbar is at 0%
…ould be hidden when value is at 0%
|
Argh, forgot to add the class back to valueDiv on create. Please forgive my noobness. :( |
|
Sorry for the notification spam, I thought I would have to create a new pull request with my latest commit but it seems this pull request is living. I'm learning. |
|
Merged, thanks! In the future, don't forget a unit test; I took care of it this time. |
thg2k
pushed a commit
to thg2k/jquery-ui
that referenced
this pull request
Oct 18, 2011
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of toggling the "ui-widget-header" class, toggle visibility of valueDiv, since other classes may be styling the div.
http://bugs.jqueryui.com/ticket/7231