Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar: Add working year / month select demo #1803

Merged
merged 4 commits into from May 17, 2017

Conversation

@fnagel
Copy link
Member

fnagel commented Apr 11, 2017

No description provided.

Copy link
Member

scottgonzalez left a comment

Let's do this as an extension instead and add the old options back.

return title
.append( month )
.append( " " )
.append( year );

This comment has been minimized.

Copy link
@scottgonzalez

scottgonzalez Apr 11, 2017

Member

Isn't this order locale specific?

changeYear: true
$.widget( "custom.calendarWithSelect", $.ui.calendar, {
_buildTitle: function() {
var title = $( "<div>", { role: "alert", id: this.gridId + "-month-label" } ),

This comment has been minimized.

Copy link
@scottgonzalez

scottgonzalez Apr 11, 2017

Member

Hmm...Can we come up with a way to avoid using internal properties like this.gridId?

}
} );

for ( ;i < 12; i++ ) {

This comment has been minimized.

Copy link
@scottgonzalez

scottgonzalez Apr 11, 2017

Member

space after semicolon

@fnagel fnagel force-pushed the fnagel:datepicker-month-year-select branch from ce6f34a to 2ac81ad Apr 12, 2017
@fnagel fnagel requested a review from jzaefferer Apr 12, 2017
@fnagel fnagel force-pushed the fnagel:datepicker-month-year-select branch from 2ac81ad to d6de67a Apr 14, 2017
@fnagel

This comment has been minimized.

Copy link
Member Author

fnagel commented Apr 14, 2017

@scottgonzalez Updated the branch. Please review!

Tests fail again, but this time I'm not able to reproduce it locally :-/

Copy link
Member

scottgonzalez left a comment

I'm fine with merging this even with the failing test since we have a plan to address that. You can just comment out that test for now so that we can identify new failures easily.

@fnagel fnagel merged commit d6de67a into jquery:datepicker May 17, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.