Demos: Fix a typo with an extra semicolon #1812
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Apologies if I misunderstood the authors file and I wasn't meant to add myself to that. If you'd like me to remove that change let me know if a second commit or amending this one would be preferable. |
No problem. That file is auto-generated by a build task. I removed your edit to that file when I merged. Your name will be added prior to the next release. Thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highly trivial typo but this extra semicolon was causing
ctxto be declared as a global variable instead of a local one. It could potentially cause troubles if someone enables strict mode.This potential problem was found using lgtm.com where we analyse many open source projects. This repo has basically no other alerts but you can see the results of your dependencies or in context of other JavaScript projects.