Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation for Urdu language #1860

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

abdullah1908
Copy link

Hi,

Added new file named as datepicker-ur.js for Urdu and added Urdu translation strings for Datepicker. I am a native Urdu speaker and compiled the Urdu translation itself.

Best Regards,
Abdullah

@jsf-clabot
Copy link

jsf-clabot commented Apr 29, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@abdullah1908 abdullah1908 changed the title Add Localization for Urdu language Add translation for Urdu language Apr 29, 2018
@scottgonzalez
Copy link
Member

Thanks, but datepicker is undergoing a rewrite in which all locale data will come from CLDR. As such, we are not accepting any new translations.

@abdullah1908
Copy link
Author

That's great 👍
Thanks for the quick followup @scottgonzalez
Have a great day!

@fnagel
Copy link
Member

fnagel commented Jul 27, 2020

Things have changed. We are adding localization files again.

@fnagel fnagel reopened this Jul 27, 2020
@fnagel
Copy link
Member

fnagel commented Jul 27, 2020

We need some more reviews of the localization before merging this. Please see here for more info: https://jqueryui.pbworks.com/w/page/139157592/Adding%20translations

@fnagel fnagel self-assigned this Jul 27, 2020
"جولائی", "اگست", "ستمبر", "اکتوبر", "نومبر", "دسمبر"],
monthNamesShort: ["1", "2", "3", "4", "5", "6",
"7", "8", "9", "10", "11", "12"],
dayNames: [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to one line here to be consistent with all other files.

currentText: "آج",
monthNames: ["جنوری", "فروری", "مارچ", "اپریل", "مئی", "جون",
"جولائی", "اگست", "ستمبر", "اکتوبر", "نومبر", "دسمبر"],
monthNamesShort: ["1", "2", "3", "4", "5", "6",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No short names in Urdu?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there are no short names for months in Urdu.

@abdullah1908
Copy link
Author

@fnagel is there any update on this PR?

@fnagel
Copy link
Member

fnagel commented Oct 21, 2020

@abdullah1908 We need some more reviews regarding the content, see https://jqueryui.pbworks.com/w/page/139157592/Adding%20translations What you could do right away would be implementing my change requests and fix the CGL errors.

Base automatically changed from master to main February 19, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

5 participants