Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Include all the files published to the CDN in npm/Bower packages #2059

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Build: Include all the files published to the CDN in npm/Bower packages #2059

merged 1 commit into from
Mar 23, 2022

Conversation

mgol
Copy link
Member

@mgol mgol commented Mar 4, 2022

Both unminified & minified versions of JS & CSS files are included, for all
themes, as well as images.

Fixes gh-2011

@mgol
Build: Include all the files published to the CDN in npm/Bower packages
744477d 
Both unminified & minified versions of JS & CSS files are included, for all
themes, as well as images.

Fixes jquerygh-2011
@mgol mgol added this to the 1.13.2 milestone Mar 4, 2022
@mgol mgol requested a review from fnagel March 4, 2022 23:29
@mgol mgol self-assigned this Mar 4, 2022
@mgol mgol mentioned this pull request Mar 4, 2022
Closed
fnagel
fnagel approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@fnagel fnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 by reading

I'm not aware how the release script works so not a really reliable review.

@mgol
Copy link
Member Author

mgol commented Mar 10, 2022

I'm not aware how the release script works so not a really reliable review.

The main thing here is that in the jquery-ui package there will be a new dist folder that will contain everything we upload to the CDN; if this was included in the 1.13.1 release then dist in the npm package would contain everything from https://github.com/jquery/codeorigin.jquery.com/tree/main/cdn/ui/1.13.1, maintaining the directory structure.

Are you OK with that? The current jquery-ui package has no dist folder.

@mgol mgol requested a review from fnagel March 10, 2022 15:35
@mgol
Copy link
Member Author

mgol commented Mar 14, 2022

@fnagel can you say if you give a green light to the above?

@fnagel
Copy link
Member

fnagel commented Mar 23, 2022

@mgol Just for my understanding, we then have those packages:

The only new thing is that the Github tag / release download then includes the processed files, right?

@mgol
Copy link
Member Author

mgol commented Mar 23, 2022

@fnagel yes, my understanding is the same.

@mgol mgol merged commit e21a254 into jquery:main Mar 23, 2022
@mgol mgol deleted the js-css-files-in-package branch March 23, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnagel fnagel fnagel approved these changes

Assignees

@mgol mgol

Labels
Comp: Build
Milestone
1.13.2
Development

Successfully merging this pull request may close these issues.

Pre-built version of jquery-ui
2 participants
@mgol @fnagel