Ticket #4578: adding tab moves targeted panel #251
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 11, 2011 17:52
…e first tab in a line to spaces no matter what you do.
| @@ -808,7 +808,11 @@ if ( $.uiBackCompat !== false ) { | |||
|
|
|||
| if ( index >= this.lis.length ) { | |||
| li.appendTo( this.list ); | |||
| panel.appendTo( this.list[ 0 ].parentNode ); | |||
| if( index > 0 ){ | |||
There was a problem hiding this comment.
the spacing here is wrong, it needs to be if ( index > 0 ) {
|
This doesn't look right, you're appending a panel after an anchor? |
|
This also doesn't solve the problem as suggested. If the panel already exists, it shouldn't be moved. See http://groups.google.com/group/jquery-ui-dev/browse_thread/thread/87bbd62c9f03f156 |
added 2 commits
May 11, 2011 12:20
…e don't want to move it or create a new panel.
|
I'm not sure while my additional commits aren't showing in this pull request. Should I close and just open a new pull request?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the panel to be added doesn't have an index value append the tab to be added to the list's parent. Otherwise insert the tab after the last existing panel.
Fixes ticket http://bugs.jqueryui.com/ticket/4578