CSS: Changed the :active selector to *. Fixed #6757 - .ui-widget :active { outline: none; } causes slowness in FF #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ive { outline: none; } causes slowness in FF
|
That's crazy aggressive and kills focus outlines. We discussed this in the meeting yesterday and we think we want to go even less aggressive than :active. The best solution is probably to remove this rule and add specific rules for individual widgets. |
|
Forgot about focus. I knew it was aggressive but thought :active was really aggressive anyway and went with it. Specific rules for each widget would make more sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSS: Changed the :active selector to *. Fixed #6757 - .ui-widget :active { outline: none; } causes slowness in FF
This accomplishes the same effect and should not negatively effect any other default element styles.