Skip to content

Conversation

JCall-Engineer
Copy link

Datepicker: changed default button text to 'Pick Date' on line 69. Fixed #7467 - Datepicker icon should have more descriptive alt text

…xed #7467 - Datepicker icon should have more descriptive alt text
@gnarf
Copy link
Member

gnarf commented Jun 12, 2011

I'm a little torn about changing the default option value here. Although "Pick Date" makes more sense than "..." for a default in my opinion, don't forget that this is also the plain "button text" when you don't use an image too: http://cl.ly/3V2u360m1X0L1q3s280s

Also - This broke a unit test, here is a commit to fix it: gnarf@21b9ba7

I'm waiting on another opinion here, @scottgonzalez @rdworth @jzaefferer

@scottgonzalez
Copy link
Member

This also causes almost every locale to default to an invalid value.

@JCall-Engineer
Copy link
Author

:S And I thought i was picking a simple change/enhancement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants