Dialog: added options to the buttons for icons. Fixed #6830 - Allow Icons to be specified for Dialog buttons #423

Closed
wants to merge 1 commit into
from

5 participants

@JohnArcher

This is an absolut must-have! Thanks for doing the code! I really hope this will be worked into jquery-ui, as I really hate this nasty .find('button:contains("Cancel") stuff.

EDIT: Oh, one more thing: What about additional implementing 'lable' and 'disabled' options, like it is used in the jquery-ui-button plugin (http://jqueryui.com/demos/button/) Would make sense, at least 'lable'.

Thanks again!

Greetings!

@scottgonzalez
jQuery Foundation member

It looks like you linked to the wrong jsbin for your demo. Also, it looks like this will default to not showing text for buttons, since showText will default to being undefined.

@djQuery

Sorry about the demo have recreated it here. http://jsbin.com/ifiyiv/5/edit
If showText is defaulting to false it doesn't seem to be having an impact on the results.

Could have sworn that disabled was working any way.

@scottgonzalez
jQuery Foundation member

That demo page doesn't work either.

@djQuery

Well this one definitely works, have tested in IE, FF, Chrome, Opera and Safari
http://davidjquery.com/jquery-ui-1/demos/dialog/buttons.html

@mikesherov
jQuery Foundation member

@djQuery, can you please update this pull request to address @scottgonzalez's concerns mentioned here: #423 (comment)

Also, could you possibly add some unit tests supporting this change and make sure the demo page you linked to works?

@jzaefferer
jQuery Foundation member

Implemented the fix for #6830 in c77ca67 along with a test, inside the dialog branch, see #794.

@jzaefferer jzaefferer closed this Nov 17, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment