Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Core: Removed .disableSelection() #485

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Owner

scottgonzalez commented Oct 1, 2011

ZOMG!

Owner

scottgonzalez commented Oct 1, 2011

We should remove this from all of the demos and the plugins now. Deprecate the methods in 1.9 and remove them in 2.0.

Owner

scottgonzalez commented Oct 1, 2011

Should fix #7737.

Owner

scottgonzalez commented Oct 1, 2011

Close #7735 as wontfix.

Owner

gnarf commented Oct 12, 2011

Agree - if we don't actually need it for anything... Why do we have it?

Owner

scottgonzalez commented Oct 12, 2011

Apparently someone thought we needed it...

Owner

scottgonzalez commented Oct 27, 2011

Quick testing in IE 6 shows that this causes selection regressions in the delayed draggable demos. Apparently we have to prevent the default action of mousemove all the time. We're currently only preventing it if we've already met the distance/delay tolerance. I'm not sure if there are any negative side effects to always preventing the default action.

@scottgonzalez scottgonzalez commented on the diff May 15, 2012

ui/jquery.ui.dialog.js
@@ -142,7 +142,7 @@ $.widget("ui.dialog", {
.html( title )
.prependTo( uiDialogTitlebar );
- uiDialogTitlebar.find( "*" ).add( uiDialogTitlebar ).disableSelection();
+ uiDialogTitlebar.find( "*" ).add( uiDialogTitlebar );
@scottgonzalez

scottgonzalez May 15, 2012

Owner

This whole line should've been deleted.

Member

mikesherov commented Nov 5, 2012

Is this landable now that the new site is launched?

Owner

scottgonzalez commented Nov 5, 2012

I think there needs to be another round of testing in IE. I don't remember if this was just an IE6 problem, but I'm assuming it wasn't.

Owner

scottgonzalez commented Nov 19, 2012

Testing PR notification.

@scottgonzalez scottgonzalez reopened this Nov 19, 2012

disableSelection was causing issues in our site while using .sortable in IE9. When we call disableSelection after .sortable, in IE9 it makes the textboxes inside of the sortable divs unselectable, in Chrome and Firefox the textboxes are selectable. So far in our testing after removing the disableSelection line after .sortable I haven't seen any adverse affects.

@scottgonzalez scottgonzalez deleted the scottgonzalez:disableSelection branch Jan 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment