Core: Removed .disableSelection() #485
Conversation
|
We should remove this from all of the demos and the plugins now. Deprecate the methods in 1.9 and remove them in 2.0. |
|
Should fix #7737. |
|
Close #7735 as wontfix. |
|
Agree - if we don't actually need it for anything... Why do we have it? |
|
Apparently someone thought we needed it... |
|
Quick testing in IE 6 shows that this causes selection regressions in the delayed draggable demos. Apparently we have to prevent the default action of mousemove all the time. We're currently only preventing it if we've already met the distance/delay tolerance. I'm not sure if there are any negative side effects to always preventing the default action. |
| @@ -142,7 +142,7 @@ $.widget("ui.dialog", { | |||
| .html( title ) | |||
| .prependTo( uiDialogTitlebar ); | |||
|
|
|||
| uiDialogTitlebar.find( "*" ).add( uiDialogTitlebar ).disableSelection(); | |||
| uiDialogTitlebar.find( "*" ).add( uiDialogTitlebar ); | |||
There was a problem hiding this comment.
This whole line should've been deleted.
|
Is this landable now that the new site is launched? |
|
I think there needs to be another round of testing in IE. I don't remember if this was just an IE6 problem, but I'm assuming it wasn't. |
|
Testing PR notification. |
|
disableSelection was causing issues in our site while using .sortable in IE9. When we call disableSelection after .sortable, in IE9 it makes the textboxes inside of the sortable divs unselectable, in Chrome and Firefox the textboxes are selectable. So far in our testing after removing the disableSelection line after .sortable I haven't seen any adverse affects. |
ZOMG!