Fixes #7396: Selectable _create() slow on IE6 with large number of selectees #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lectees The position (offset and width/height) computation is only used by the '_mouseDrag' method. So, by moving the computation in '_mouseStart' method: - we are removing useless (and sometimes slow on big selectable) computations from widget initialization - we are computing the position for all 'selectees' in one shot and using the browser cache: since we are not changing the render (by adding/removing CSS class) between the different calls to offset/outerWidth/outerHeight, the browser does not need recompute the render and can cache some results
|
The refresh method should be able to be called at any time, including during a selection. This breaks that functionality by clearing the data on refresh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The position (offset and width/height) computation is only used by the '_mouseDrag' method. So, by moving the computation in '_mouseStart' method: